This repository has been archived by the owner on Jan 3, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: check connectivity of external links via GitHub action #353
*: check connectivity of external links via GitHub action #353
Changes from 15 commits
6074146
520806b
8e2dc46
7ceef22
bde59d5
9f31ed3
82a5d2f
c4801f0
4a6c2a1
9c7d070
4f4b712
e31d5f0
7e606e9
5a6ba35
090fc15
6e5e6a1
6802163
2390174
e285726
43bfd08
01c1c68
2c902b0
780ec38
6b2ead5
c308e0e
0e290e0
0918796
7628193
81661a9
97af4bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新 workflow 的功能是内链(相对链接)和外链(绝对链接)都会查吗 @csuzhangxc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的。但不能正确检测出锚文本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内链 和 内链锚文本 的检查都已经有了,在 ci.yaml 的 Verify links 和 Verify link anchors 两个 step 中实现了。学程哥新加的这个可以配置成只检查 外链 吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果方便的话,最好把检查外链的这个 action 也写到 ci.yaml 那个文件里,写成和 Verify links、Verify link anchors 并列的一个新的 step,就不要另起一个 workflow 了,怎么样? @csuzhangxc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
想的是单开一个 workflow,不是
Required
。这样检查异常时,也还是能 merge?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,这样的话也可以,就不必因为 pr 未涉及的 404 外链而 block merge 了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请教下,上面的「Check external links in zh files」那一步没有 id,如果只有 zh 有 error、en 没有 error,下面的 ${{ steps.lc.outputs.exit_code }} 会是 1 吗? @csuzhangxc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啊。我的错误,都需要加 id、都需要判断
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯,学程哥帮忙提个 pr 改下?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#370 PTAL