Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

*: add exit_code check for zh link checking #370

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

csuzhangxc
Copy link
Member

What is changed, added or deleted? (Required)

add exit_code check for external link check on zh.

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@csuzhangxc
Copy link
Member Author

@yikeke PTAL

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@yikeke yikeke added needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. translation/no-need The changes in this PR don't need to be translated. labels Sep 9, 2020
@yikeke yikeke merged commit b85a25d into pingcap:master Sep 9, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 9, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #371

ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 9, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #372

yikeke pushed a commit that referenced this pull request Sep 9, 2020
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Xuecheng Zhang <[email protected]>
yikeke pushed a commit to yikeke/docs-tidb-operator that referenced this pull request Sep 9, 2020
ti-srebot added a commit that referenced this pull request Sep 9, 2020
@csuzhangxc csuzhangxc deleted the fix-link-check branch September 10, 2020 03:12
yikeke added a commit to pingcap/docs-tidb-operator that referenced this pull request Nov 2, 2020
* .github: add external link check

* align pingcap/docs-dm#370

* update regex to exclude links

* fix dead external links

Signed-off-by: Ran <[email protected]>

Co-authored-by: Ran <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants