-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: add external link check #694
Conversation
There are many github bad requests being reported. I think we only need to check github links with a file name suffix such as Or we can skip checking releases/release-xxx.md files because in the files there are many links that can be ignored. Do you have some clue to exclude the reported github links? @csuzhangxc |
liche (the tool used in but in this repo, maybe you can remove |
Okay, I'll look into that. Thanks~ |
@csuzhangxc, @ran-huang, PTAL. |
1 similar comment
@csuzhangxc, @ran-huang, PTAL. |
@csuzhangxc, @ran-huang, PTAL. |
The
Could you help fix them? @ran-huang |
Sure. |
Signed-off-by: Ran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-1.0 in PR #816 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-1.1 in PR #817 |
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Keke Yi <[email protected]>
* cherry pick #694 to release-1.0 Signed-off-by: ti-srebot <[email protected]> * resolve conflicts * fix external links Signed-off-by: Ran <[email protected]> * test Co-authored-by: Keke Yi <[email protected]> Co-authored-by: yikeke <[email protected]> Co-authored-by: Ran <[email protected]>
What is changed, added or deleted? (Required)
A migration from pingcap/docs-dm#353
Note this external link check isn't required to pass, in order to prevent false alarms from blocking PR merge.
The current regex exclusions is:
http://172.*|https://github.com/.*/pull/.*|https://github.com/.*/issues/.*|https://github.com/[^.\n]*$|http://127.0.0.1.*|http://localhost.*|.*.md
Meaning the check will skip checking the URLs matching the above patterns.
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?