-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: use ExtraHandleColumn as PK when generating TablePath #11959
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11959 +/- ##
===========================================
Coverage 81.2949% 81.2949%
===========================================
Files 444 444
Lines 95092 95092
===========================================
Hits 77305 77305
Misses 12305 12305
Partials 5482 5482 |
@francis0407 Please add proper labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@francis0407 merge failed. |
/build |
/run-cherry-picker |
cherry pick to release-2.1 failed |
cherry pick to release-3.0 failed |
cherry pick to release-3.1 failed |
What problem does this PR solve?
Before this PR:
After this PR:
What is changed and how it works?
This PR makes
getPKIsHandleCol()
returnExtraHandleColumn
instead ofnil
when the table has no PK.Check List
Tests
Release note
When the table uses
_tidb_rowid
as Handle, we can correctly generate a TableScan that can keep the order of_tidb_rowid
. For example,select max(_tidb_rowid) from t
won't require aSort
anymore.