Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use ExtraHandleColumn as PK when generating TablePath (#11959) (#13095) #13291

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 8, 2019

cherry-pick #13095 to release-3.1


What problem does this PR solve?

Cherry pick #11959 to branch release-3.0

What is changed and how it works?

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

When the table uses _tidb_rowid as Handle, we can correctly generate a TableScan that keeps the order of _tidb_rowid. For example, select max(_tidb_rowid) from t won't require a Sort anymore.

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 8, 2019

/run-all-tests

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 8, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 8, 2019

Your auto merge job has been accepted, waiting for 13247

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4ee5e44 into pingcap:release-3.1 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants