expression: implement vectorized evaluation for 'builtinDurationAnyValueSig' #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsthght
requested review from
qw4990,
Reminiscent,
SunRunAway and
XuHuaiyu
as code owners
|
/rebuild |
SunRunAway
reviewed
Oct 10, 2019
| } | ||
|
|
||
| func (b *builtinDurationAnyValueSig) vecEvalDuration(input *chunk.Chunk, result *chunk.Column) error { | ||
| return errors.Errorf("not implemented") | ||
| if err := b.args[0].VecEvalDuration(b.ctx, input, result); err != nil { |
There was a problem hiding this comment.
use b.args[0].VecEvalDuration(b.ctx, input, result) for shortly?
Codecov Report
@@ Coverage Diff @@
## master #12605 +/- ##
===============================================
- Coverage 79.8924% 79.8754% -0.017%
===============================================
Files 460 460
Lines 103533 103391 -142
===============================================
- Hits 82715 82584 -131
+ Misses 14752 14746 -6
+ Partials 6066 6061 -5 |
wshwsh12
added
status/can-merge
|
/run-all-tests |
|
@tsthght merge failed. |
|
/run-all-tests |
|
/run-unit-test |
|
/run-all-tests |
|
/run-unit-test |
|
@tsthght Please format the file |
|
@tsthght Please format |
qw4990
approved these changes
Oct 11, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinDurationAnyValueSig, for #12176
What is changed and how it works?
Check List
Tests