Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for 'builtinDurationAnyValueSig' #12605

Merged
merged 8 commits into from
Oct 11, 2019
Merged

expression: implement vectorized evaluation for 'builtinDurationAnyValueSig' #12605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c916b71
expression: implement vectorized evaluation for 'builtinDurationAnyVa…
tsthght Oct 10, 2019
648bdbe
refine
tsthght Oct 10, 2019
02346a2
Merge branch 'master' into builtinDurationAnyValueSig
ngaut Oct 11, 2019
4e70cc0
Merge branch 'master' into builtinDurationAnyValueSig
ngaut Oct 11, 2019
50d0a89
Merge branch 'master' into builtinDurationAnyValueSig
qw4990 Oct 11, 2019
b168c91
Merge branch 'master' into builtinDurationAnyValueSig
tsthght Oct 11, 2019
efcbad4
Merge branch 'master' into builtinDurationAnyValueSig
tsthght Oct 11, 2019
25c1775
gofmt
tsthght Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions expression/builtin_miscellaneous_vec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ func (b *builtinLockSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) er
}

func (b *builtinDurationAnyValueSig) vectorized() bool {
return false
return true
}

func (b *builtinDurationAnyValueSig) vecEvalDuration(input *chunk.Chunk, result *chunk.Column) error {
return errors.Errorf("not implemented")
return b.args[0].VecEvalDuration(b.ctx, input, result)
}

func (b *builtinIntAnyValueSig) vectorized() bool {
Expand Down
3 changes: 3 additions & 0 deletions expression/builtin_miscellaneous_vec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ var vecBuiltinMiscellaneousCases = map[string][]vecExprBenchCase{
ast.IsIPv4: {
{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETString}},
},
ast.AnyValue: {
{retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETDuration}},
},
ast.NameConst: {
{retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETString, types.ETDuration}},
},
Expand Down