apply only one sign

plotly · Mar 29, 2020 · ce2e206 · ce2e206
1 parent 7511cb1
commit ce2e206
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js
@@ -566,16 +566,11 @@ module.exports = function setConvert(ax, fullLayout) {
                     ax._lBreaks += Math.abs(brk.max - brk.min);
                 }
 
-                var axReverse = rl0 > rl1;
-                var signAx = axReverse ? -1 : 1;
-
                 var flip = isY;
-                if(ax.range[0] > ax.range[1]) flip = !flip;
-                if(flip) {
-                    ax._rangebreaks.reverse();
-                }
-
-                ax._m2 = (isY ? -1 : 1) * ax._length / (rl1 - rl0 - ax._lBreaks * signAx);
+                if(rl0 > rl1) flip = !flip;
+                if(flip) ax._rangebreaks.reverse();
+                var sign = flip ? -1 : 1;
+                ax._m2 = sign * ax._length / (Math.abs(rl1 - rl0) - ax._lBreaks);
 
                 if(isY) {
                     // N.B. top to bottom (negative coord, positive px direction)
@@ -586,7 +581,10 @@ module.exports = function setConvert(ax, fullLayout) {
 
                 for(i = 0; i < ax._rangebreaks.length; i++) {
                     brk = ax._rangebreaks[i];
-                    ax._B.push(ax._B[ax._B.length - 1] - (isY ? -1 : 1) * ax._m2 * (brk.max - brk.min) * signAx);
+                    ax._B.push(
+                        ax._B[ax._B.length - 1] -
+                        sign * ax._m2 * (brk.max - brk.min)
+                    );
                 }
 
                 // fill pixel (i.e. 'p') min/max here,