Histogram edge cases #2028
Merged
Histogram edge cases #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Sep 21, 2017
src/traces/bar/sieve.js
Outdated
| @@ -48,7 +48,7 @@ function Sieve(traces, separateNegativeValues, dontMergeOverlappingData) { | |||
|
|
|||
| var dv = Lib.distinctVals(positions); | |||
| this.distinctPositions = dv.vals; | |||
| if(dv.vals.length === 1 && width1) this.minDiff = width1; | |||
| if(dv.vals.length === 1 && width1 !== Infinity) this.minDiff = width1; | |||
There was a problem hiding this comment.
@n-riesco you wrote some fantastic tests of bar chart edge cases, really saved us here!
etpinard
reviewed
Sep 21, 2017
src/traces/histogram/calc.js
Outdated
| // Edge case: single-valued histogram overlaying others | ||
| // Use them all together to calculate the bin size for the single-valued one | ||
| if(isOverlay && binSpec._count === 1 && pa.type !== 'category') { | ||
| // trace[binAttr] = binSpec; |
There was a problem hiding this comment.
thanks - 🔪 in c057d25
|
Solid comments and solid tests 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1978 - some edge cases of single-bin histogram handling
cc @etpinard