Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram edge cases #2028

Merged
merged 5 commits into from
Sep 22, 2017
Merged

Histogram edge cases #2028

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9498bb
fix part 1 of #1978 - keep bin width and trim zeros from 1-bin histog…
alexcjohnson Sep 20, 2017
968f742
fix part 2 of #1978 - autobin size for single-value overlaid histograms
alexcjohnson Sep 21, 2017
9959341
fix histogram2d test for _count field
alexcjohnson Sep 21, 2017
bcebc8a
fix sieve modification -> for single-item bar traces
alexcjohnson Sep 21, 2017
c057d25
lint
alexcjohnson Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/traces/bar/sieve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function Sieve(traces, separateNegativeValues, dontMergeOverlappingData) {

var dv = Lib.distinctVals(positions);
this.distinctPositions = dv.vals;
if(dv.vals.length === 1 && width1) this.minDiff = width1;
if(dv.vals.length === 1 && width1 !== Infinity) this.minDiff = width1;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n-riesco you wrote some fantastic tests of bar chart edge cases, really saved us here!

else this.minDiff = Math.min(dv.minDiff, width1);

this.binWidth = this.minDiff;
Expand Down