Skip to content

Commit

Permalink
Merge branch 'epic/df' into df/cell_navigation
Browse files Browse the repository at this point in the history
* epic/df:
  Make sure that `Id` type is kept in type stub (#1455)
  Remove outdated comments
  • Loading branch information
schloerke committed Jun 10, 2024
2 parents d83f043 + 0092ccb commit 5095fa1
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 12 deletions.
2 changes: 0 additions & 2 deletions shiny/_fileupload.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

import copy
Expand Down
2 changes: 0 additions & 2 deletions shiny/_namespaces.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

import re
Expand Down
2 changes: 0 additions & 2 deletions shiny/input_handler.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

__all__ = ("input_handlers",)
Expand Down
3 changes: 3 additions & 0 deletions shiny/module.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
P = ParamSpec("P")
R = TypeVar("R")

# Ensure that Id type is not stripped out from .pyi file when generating type stubs
_: Id # type: ignore


@no_example()
def ui(fn: Callable[P, R]) -> Callable[Concatenate[str, P], R]:
Expand Down
2 changes: 0 additions & 2 deletions shiny/plotutils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# pyright: reportUnknownArgumentType=false

# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

__all__ = ("brushed_points", "near_points")
Expand Down
2 changes: 0 additions & 2 deletions shiny/session/_session.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

__all__ = ("Session", "Inputs", "Outputs")
Expand Down
2 changes: 0 additions & 2 deletions shiny/session/_utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Needed for types imported only during TYPE_CHECKING with Python 3.7 - 3.9
# See https://www.python.org/dev/peps/pep-0655/#usage-in-python-3-11
from __future__ import annotations

__all__ = (
Expand Down

0 comments on commit 5095fa1

Please sign in to comment.