Make sure that Id type is kept in type stub
#1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
added a commit
that referenced
this pull request
Jun 10, 2024
* epic/df: Make sure that `Id` type is kept in type stub (#1455) Remove outdated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when generating type stubs with pyright, the
Idtype would get stripped out of module.py because it was only used inside of functions in the file. This causes the pyright/pylance LSP to report the type asUnknowninstead of asId.After this change, the
Idtype is kept inmodule.py, and the LSP correctly reports the type asIdinstead ofUnknown.