Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data frame): Enable cell selection and editable cells #1454

Merged
merged 21 commits into from
Jun 13, 2024

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jun 6, 2024

TODO:

  • Remove restriction
  • Improve keyboard navigation on selected cell
  • Require selected cell to be double clicked to enter
  • Allow selected cell to have typed letter enter edit mode
  • Pressing Enter with a selected row begins editing the first visible column in that row

schloerke added 4 commits June 4, 2024 13:30
* epic/df:
  feat(tests): Add shiny.pytest, shiny.run and shiny.playwright (#1448)
…a dict of params rather than many individual unnamed params
@schloerke schloerke added the data frame Related to @render.data_frame label Jun 6, 2024
@schloerke schloerke added this to the v0.11.0 milestone Jun 6, 2024
@schloerke schloerke force-pushed the df/cell_navigation branch from 6bbc2b5 to eb029f2 Compare June 10, 2024 21:15
@jcheng5 jcheng5 changed the base branch from epic/df to main June 11, 2024 17:44
@schloerke schloerke marked this pull request as ready for review June 13, 2024 04:12
@schloerke schloerke enabled auto-merge June 13, 2024 04:12
@schloerke schloerke added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 4a8a528 Jun 13, 2024
32 checks passed
@schloerke schloerke deleted the df/cell_navigation branch June 13, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data frame Related to @render.data_frame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants