Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML multiline comments being rendered #246

Closed
eragon512 opened this issue May 4, 2019 · 1 comment · Fixed by #262
Closed

HTML multiline comments being rendered #246

eragon512 opened this issue May 4, 2019 · 1 comment · Fixed by #262
Labels
bug

Comments

@eragon512
Copy link
Contributor

eragon512 commented May 4, 2019 •
edited
Loading

Steps to reproduce:

Some text
<!-- This is a
multiline
comment -->

Expected output:

Some text

Actual Output:

Some text <!-- This is a multiline comment -->
@eragon512 eragon512 mentioned this issue May 4, 2019
Closed
@quantizor quantizor added the bug label May 7, 2019
@quantizor
Copy link
Owner

PR welcome!

eragon512 added a commit to eragon512/markdown-to-jsx that referenced this issue Aug 7, 2019
@eragon512
Fix HTML multiline comments bug (quantizor#246)
df83a77
@eragon512 eragon512 mentioned this issue Aug 7, 2019
Merged
eragon512 added a commit to eragon512/markdown-to-jsx that referenced this issue Aug 7, 2019
@eragon512
Fix HTML multiline comments bug (quantizor#246)
86c44c1
eragon512 added a commit to eragon512/markdown-to-jsx that referenced this issue Aug 8, 2019
@eragon512
Fix HTML multiline comments bug (quantizor#246)
72c96b3
eragon512 added a commit to eragon512/markdown-to-jsx that referenced this issue Sep 11, 2019
@eragon512
Fix HTML multiline comments bug (quantizor#246)
5aa8010
eragon512 added a commit to eragon512/markdown-to-jsx that referenced this issue Sep 11, 2019
@eragon512
Fix HTML multiline comments bug (quantizor#246)
5f39545
quantizor pushed a commit that referenced this issue Sep 12, 2019
@eragon512 @quantizor
Fix HTML multiline comments bug (#246) (#262)
7b55be6
This was referenced Mar 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HTML multiline comments bug (#246) eragon512/markdown-to-jsx
2 participants
@quantizor @eragon512