Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate eNote signatures & improve document and checksum checks #47

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Validate eNote signatures & improve document and checksum checks #47

merged 2 commits into from
Sep 28, 2022

Conversation

rpatel-figure
Copy link
Collaborator

@rpatel-figure rpatel-figure commented Sep 26, 2022 •
edited
Loading

Context

While we're adding validation for the new eNote borrower signature image document list, let's improve the contracts' overalll file checking logic.

Changes

Minor

  • Require fileName field to not be empty in any DocumentMetadata
  • Require that borrower signature images in an eNote recording are fully populated DocumentMetadatas with unique checksums among the input
  • Fix duplicate checksums in input servicing documents not actually raising a violation
  • Change duplicate checksum logic in a few places to only raise violations if the duplicate is not blank — the per-item validations can enforce the requirement separately, to reduce clutter in the resulting exception message

@rpatel-figure rpatel-figure added enhancement An enhancement to existing code minor Minor changes, either non-breaking or close to it labels Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Sep 26, 2022 •
edited
Loading

Test Results

  12 files  ±0    12 suites  ±0   5m 21s ⏱️ + 2m 0s
  51 tests ±0    45 ✔️ ±0    6 💤 ±0  0 ❌ ±0 
127 runs  +1  116 ✔️ +1  11 💤 ±0  0 ❌ ±0 

Results for commit 5676741. ± Comparison against base commit 02222fa.

♻️ This comment has been updated with latest results.

@rpatel-figure rpatel-figure changed the title Validate eNote signature images, require file names on all documents Validate eNote signature images, require file names on documents, improve checksum checks Sep 27, 2022
@rpatel-figure rpatel-figure force-pushed the ravipatel/support-enote-signatures-1 branch from f6b7a3c to 5676741 Compare September 27, 2022 16:14
@rpatel-figure rpatel-figure marked this pull request as ready for review September 27, 2022 16:24
cworsnop-figure
cworsnop-figure approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@cworsnop-figure cworsnop-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpatel-figure rpatel-figure changed the title Validate eNote signature images, require file names on documents, improve checksum checks Validate eNote signatures & improve document and checksum checks Sep 28, 2022
@rpatel-figure rpatel-figure merged commit 4878ab7 into main Sep 28, 2022
@rpatel-figure rpatel-figure deleted the ravipatel/support-enote-signatures-1 branch September 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rromanowski-figure rromanowski-figure rromanowski-figure approved these changes

@cworsnop-figure cworsnop-figure cworsnop-figure approved these changes

@dkneisly-figure dkneisly-figure Awaiting requested review from dkneisly-figure

Assignees
No one assigned
Labels
enhancement An enhancement to existing code minor Minor changes, either non-breaking or close to it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpatel-figure @rromanowski-figure @cworsnop-figure