Relax validation for loan funding data

[rpatel-figure]

Context

Relaxing multiple data validations made for specific fields in the funding field, particularly around effective times, to only check for a valid (AKA non-future) timestamp if the field itself is set to a non-default value. This supports cases where

• times are not set on individual disbursement entries, in favor of setting the top-level start & end times
• when funding is cancelled, unstarted, or incomplete

Changes

• Update funding contract's input validation to only validate specific time fields if they are set
• Treat a funding status string of "COMPLETE" the same as "COMPLETED" or "FUNDED"

[github-actions]

Test Results

  14 files  ±0    14 suites  ±0   13m 21s ⏱️ + 4m 33s
  55 tests ±0    50 ✔️ ±0    5 💤 ±0  0 ❌ ±0 
159 runs  ±0  149 ✔️ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit df5e6d4. ± Comparison against base commit 34351d4.

♻️ This comment has been updated with latest results.

[dkneisly-figure]

LGTM

[codecov-commenter]

Codecov Report

Patch coverage: 46.66% and project coverage change: -0.85 ⚠️

Comparison is base (34351d4) 80.39% compared to head (0055793) 79.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   80.39%   79.54%   -0.85%     
==========================================
  Files          19       19              
  Lines         704      709       +5     
  Branches      162      170       +8     
==========================================
- Hits          566      564       -2     
  Misses         70       70              
- Partials       68       75       +7     

Impacted Files	Coverage Δ
...enance/scope/loan/utility/FundingDataValidation.kt	82.14% <46.66%> (-5.71%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.