Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache::custom_config::content should accept Sensitive as type. #2391

Closed
dpavlotzky opened this issue Mar 8, 2023 · 2 comments
Closed

apache::custom_config::content should accept Sensitive as type. #2391

dpavlotzky opened this issue Mar 8, 2023 · 2 comments
Labels
community

Comments

@dpavlotzky
Copy link
Contributor

Use Case

I am wiring a custom config for mod_authnz_ldap that contains the LDAP bind password. The configuration is wrapped in Sensitive type (Deferred as well…) which is not accepted.

When I change the content declaration to:

Optional[Variant[String, Sensitive]] $content = undef

I can supply the Sensitive content without a problem.
dpavlotzky added a commit to dpavlotzky/puppetlabs-apache that referenced this issue Mar 8, 2023
@dpavlotzky
puppetlabs#2391 Accept Sensitive type in addition to String type
7d6c11c 
Accept Sensitive type in addition to String type for apache::custom_config::content
dpavlotzky added a commit to dpavlotzky/puppetlabs-apache that referenced this issue Mar 8, 2023
@dpavlotzky
Merge pull request #1 from dpavlotzky/puppetlabs#2391-accept-sensitiv…
2ef7c03 
…e-type

puppetlabs#2391 Accept Sensitive type in addition to String type
LukasAud added a commit that referenced this issue Mar 10, 2023
@LukasAud
Merge pull request #2392 from dpavlotzky/main
40d23ac 
#2391 Allow Sensitive type in addition to String type
@LukasAud
Copy link
Contributor

Hey @dpavlotzky, PR #2392 has been approved and merged. Hopefully that addresses your problem. We will aim to make a release soon.

@dpavlotzky
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpavlotzky @ia-content @LukasAud