Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2391 Allow Sensitive type in addition to String type #2392

Merged
merged 2 commits into from
Mar 10, 2023
Merged

#2391 Allow Sensitive type in addition to String type #2392

merged 2 commits into from
Mar 10, 2023

Conversation

dpavlotzky
Copy link
Contributor

Allow Sensitive type in addition to String type for apache::custom_config::content

@dpavlotzky
puppetlabs#2391 Accept Sensitive type in addition to String type
7d6c11c 
Accept Sensitive type in addition to String type for apache::custom_config::content
@dpavlotzky
Merge pull request #1 from dpavlotzky/puppetlabs#2391-accept-sensitiv…
2ef7c03 
…e-type

puppetlabs#2391 Accept Sensitive type in addition to String type
@dpavlotzky dpavlotzky requested a review from a team as a code owner March 8, 2023 08:20
@CLAassistant
Copy link

CLAassistant commented Mar 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apache::custom_config is a type

Breaking changes to this file WILL impact these 5 modules (exact match):
Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

LukasAud
LukasAud approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 40d23ac into puppetlabs:main Mar 10, 2023
@LukasAud LukasAud mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpavlotzky @CLAassistant @LukasAud @ia-content