Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLOptions +StdEnvVars should be set globally #487

Closed
igalic opened this issue Nov 21, 2013 · 2 comments
Closed

SSLOptions +StdEnvVars should be set globally #487

igalic opened this issue Nov 21, 2013 · 2 comments

Comments

@igalic
Copy link
Contributor

igalic commented Nov 21, 2013

Currently we have code that explicitly sets SSLOptions +StdEnvVars in a directory for ScriptAlias. We have code that sets

  <FilesMatch "\.(cgi|shtml|phtml|php)$">
    SSLOptions +StdEnvVars
  </FilesMatch>

in each SSL vhost, which, frankly, is just sad.

While I agree that it's useful to be able to override SSLOptions in a per-vhost and a per-directory context, SSLOptions +StdEnvVars is so useful for every application that is (consciously) running under SSL, that we should just set it in server context.
@antaflos antaflos mentioned this issue Nov 21, 2013
Merged
@antaflos
Copy link
Contributor

I'd argue that SSLOptions +ExportCertData could also be set globally.

@igalic
Copy link
Contributor Author

igalic commented Nov 21, 2013

To quote @rbowen:

17:29:54 <+DrBacchus> Yes, having the SSLOptions line globally seems a useful thing to do.
17:29:58 <+DrBacchus> Who uses CGI any more anyways?
17:30:03 <+DrBacchus> ;-)
17:30:26 <+DrBacchus> I mean, apart from everybody.
17:32:32 <+igalic> Yeah :\

@igalic igalic mentioned this issue Nov 21, 2013
Merged
antaflos added a commit to antaflos/puppetlabs-apache that referenced this issue Nov 22, 2013
@antaflos
No implicit <Directory> entry for ScriptAlias path
609298d 
Support for ScriptAlias currently implicitly and automatically creates
<Directory> configuration directives for the path component in a given
ScriptAlias directive. These are not useful or needed, according to the
mod_alias documentation. Fixes issue puppetlabs#486.

This change also indirectly relates to puppetlabs#487 because the implicitly
created <Directory> entry for each ScriptAlias path also had
`SSLOptions +StdEnvVars` set for that directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igalic @antaflos