Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SSLOptions StdEnvVars in server context #490

Merged
merged 1 commit into from
Nov 26, 2013
Merged

Set SSLOptions StdEnvVars in server context #490

merged 1 commit into from
Nov 26, 2013

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Nov 21, 2013

We set SSLOptions now in server context and we set it to StdEnvVars.
Thus, we no longer need the in server context to set it
for php, CGI and SSI applications.
We allow it to be overridden by the apache::mod::ssl class parameter
ssl_options. Further, we allow it to be overridden in directory
context.
Documentation for all of these has been extended and tests have been
adapted to make sense in this new context. This commit fixes #487

@apenney
Copy link
Contributor

apenney commented Nov 22, 2013

whoops, can you rebase? :)

@igalic
Copy link
Contributor Author

igalic commented Nov 22, 2013

This new commit looks a lot better.

We set `SSLOptions` now in server context and we set it to `StdEnvVars`.
Thus, we no longer need the <FilesMatch > in server context to set it
for php, CGI and SSI applications.
We allow it to be overridden by the `apache::mod::ssl` class parameter
`ssl_options`. Further, we allow it to be overridden in directory
context.
Documentation for all of these has been extended and tests have been
adapted to make sense in this new context. This commit fixes #487
apenney pushed a commit that referenced this pull request Nov 26, 2013
Set SSLOptions StdEnvVars in server context
@apenney apenney merged commit 976061b into puppetlabs:master Nov 26, 2013
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
(MODULES-9193) Revert part of MODULES-9177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants