added max_keepalive_requests #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope I got it right this time. |
|
Ah, I did the change in the params.pp just for Redhat based system and overlooked that there must also be a $max_keepalive_requests in the Debian block, else it will get an empty value. |
|
This is looking fine, and since it's lacking documentation, that might actually be a good thing™, since we still haven't merged @laurenrother's readme branch |
|
Would it be possible to rebase this on master and modify the README file to cover this new parameter? |
|
Closing in favor of the recent PR that added this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added max_keepalive_requests to the template and class, so it's more scalable and better than using a hardcoded value in the template