turning MaxKeepAliveRequests into a variable #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
following our CamelCase to under_score conversion, I think that new setting shold be max_keep_alive_requests, but that sounds… too much. |
|
Perhaps it should even be max_keepalive_requests as KeepAlive and KeepAliveTimeout have turned into keepalive and keepalive_timeout. |
maxkeepaliverequests => max_keepalive_requests
|
updated the variable, to max_keepalive_requests. I also just noticed that #623 also provides the same functionality |
|
Since your patch has docs, and tests and merges, you win ;) |
|
+1 |
igalic
added a commit
that referenced
this pull request
May 1, 2014
turning MaxKeepAliveRequests into a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 1.8 release of Subversion , it is now suggested to increase MaxKeepAliveRequests beyond its usual setting of 100 [1]. To allow the apache module to handle this situation this setting needs to be made into a variable.
[1] https://subversion.apache.org/docs/release-notes/1.8.html#neon-deleted