Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Wx front-end #62

Merged
merged 30 commits into from
Dec 19, 2024
Merged

feat: add Wx front-end #62

merged 30 commits into from
Dec 19, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Dec 8, 2024

@gnodar01, we discussed this a while back, so thought you might like to know that some progress has been made on the wx-support front. Some recent changes here (clearer model view separation) have made it easier for us to support arbitrary front-ends (qt, jupyter, and here wx) with relatively minimal additional work:

Screen.Recording.2024-12-10.at.8.15.40.PM.mov

clearly I'm not particularly skilled at styling things in wx 😂 ... but the bones are there!

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 63.01370% with 189 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2-mvc@ca31223). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/ndv/views/_wx/range_slider.py 42.97% 142 Missing ⚠️
src/ndv/views/_wx/wx_view.py 88.63% 20 Missing ⚠️
src/ndv/views/bases/graphics/_mouseable.py 36.66% 19 Missing ⚠️
src/ndv/views/_app.py 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v2-mvc      #62   +/-   ##
=========================================
  Coverage          ?   71.04%           
=========================================
  Files             ?       41           
  Lines             ?     4048           
  Branches          ?        0           
=========================================
  Hits              ?     2876           
  Misses            ?     1172           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnodar01
Copy link

Super cool @tlambert03! I'll take a deeper look this week to see how much friction is involved in integrating into CellProfiler.

@tlambert03
Copy link
Member Author

cool. over the next week or so, I'll be doing some more changes. and will try to make it clearer exactly how you are supposed to use the thing (so you're not searching too hard). And then, it would be great to get your wish-list for things that aren't yet implemented that would be particularly helpful or necessary for your main use cases

@tlambert03
Copy link
Member Author

note to self: the _WxArrayViewer isn't properly inserting the canvas widget for the pygfx backend. the fix is to use canvas_widget._subwidget ... but I want to look into a more robust fix

@tlambert03
Copy link
Member Author

ok, this is going in! :) many styles and improvements can come. it's nice just to have the framework for wx in there for now. @gnodar01, I'll ping you once there's a pre-release on pypi for you to try. so you can just pip install 'ndv[wx]' --pre and play with it

@tlambert03 tlambert03 merged commit 6c19a89 into pyapp-kit:v2-mvc Dec 19, 2024
49 checks passed
@tlambert03 tlambert03 deleted the v2-wx branch December 19, 2024 18:37
@tlambert03 tlambert03 added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants