refactor: merge in v2 "MVC" branch #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at are not integers
* add summary info * move canvas off front-end view * propogate mouse events back to controller * add mouse events on jupyter side * minor tweaks * reorg and touch up * add test * fix typing for 3.9 * fix again * revert old data wrapper * bump * add typing extensions * work for python 3.9 * typing again * fix some update inconsistencies * bump third party tests
* update pre-commit * proof of principle working example for channels. needs cleanup * decent state * create LutController * extras, and no qt * update readme * fix test * improve layout * fix syncronization
* breakout channel controller * update typos * add qt enum
…upyter views (#64) * wip * mouseable pattern * work with jupyter too * run_app * fix pygfx on jupyter * dedupe * future
* Port stats model * Port histogram model/view * Create QtHistogramView Wraps the VispyHistogramView up with some Qt widgets for control. Derived from the histogram example * Create JupyterHistogramView * Partition histogram frontends * WIP: Refactor Stats computation More view refactoring is likely necessary. A PStatsView might just want to accept the dataclass, if we even see a need to maintain that view protocol. * Remove Unpack import * Polish * Remove Vertical button I don't think that API needs to be accessible from the UI (by default) * Rename VispyHistogramView -> Canvas * Add TODO about ensuring VisPy installed * trimmed down histogram * use bincount * better data * merge in changes * reduce * remove test stats * small changes * working on mouse stuff * connect mouse events * cursor * remove test * connect gamma * app changes * remove print * make work with jupyter again * tile again --------- Co-authored-by: Gabriel Selzer <[email protected]>
* test: test controller with mocks * test matrix * no pytest-qt * setup headless * fix test * different check * pick jupyter in absense of pytestqt * remove test controller * always setup headless * pin pyside * focus on pygfx * install mesa vulkan * just pygfx * fix cov * pass examples for now * skip v1 with pyside * switch to vispy * ignore suitable pixel * extend matrix * cleanup pyproject * use mac on 313 * skip all 3.10 pyside * switch 3.13 again * again * switch matrix * revert * add comment about pyside
* test: test controller with mocks * fix test * add back examples * remove controller * skip examples on pyside * allow leaks on v1 * bump
* feat: support wx * specify extra * fix try start * thinner track * add mouse events * warn on bad data * fixup * add fixme * add to test matrix * skip wx on ubuntu * fix wx test * style(pre-commit.ci): auto fixes [...] * remove condition * change any_app * add pytest-qt to dev * add wxpythong 3.9 * fix 3.9 * add windows jup 3.9 * remove test of range_slider * remove wx-signal * fix pygfx * style(pre-commit.ci): auto fixes [...] --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: add CanvasProvider and GuiProvider classes * pragmas * fix unbound * move mouse events * allow jupyter provider without app in tests
* feat: support gpu clims * Update _utils.py Co-authored-by: Gabriel Selzer <[email protected]> * fix downcast * style(pre-commit.ci): auto fixes [...] * fix for int16 * style(pre-commit.ci): auto fixes [...] --------- Co-authored-by: Gabriel Selzer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* imshow again * move old_viewer to v1 * update * fix init * cleanup * make ArrayViewer wrapper * add gabe to authors * close method and docs * fix test * fix test and vispy histogram * move mvc * tweak model * update wrappers * expose datawrapper * remove additional layer * fix tests * fix error on channel guess * rename and fixup * fix pygfx * fix leak catch when testing pygfx with vispy in environment * style(pre-commit.ci): auto fixes [...] * fix py3.9 * update pre-commit * cleanup * remove skip on examples * fix import * remove macos pyopencl * skip pyside in examples * remove NDViewer * merge files * remove public usage of ArrayDataDisplayModel * refactor: rename ArrayDataDisplayModel to _ArrayDataDisplayModel and update data access patterns * Update src/ndv/controllers/_array_viewer.py Co-authored-by: Gabriel Selzer <[email protected]> * add clone * remove zarr astype * add another filterwarning for zarr * pin zarr * style(pre-commit.ci): auto fixes [...] * make add_histogram private * make views module private --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Selzer <[email protected]>
|
Let's do it! 💪 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 80.24% 70.44% -9.80%
==========================================
Files 16 43 +27
Lines 2237 4253 +2016
==========================================
+ Hits 1795 2996 +1201
- Misses 442 1257 +815 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges in all of the changes from the
v2-mvcintomain.