Automatic reloading of results does not work as expected #225

ruKurz · 2018-03-17T06:52:22Z

Expected Behaviour

After scrolling down the search results, next results should be loaded dynamically.

Actual Behaviour

In some cases the lazy loading stops, even there are results left.

Steps to Reproduce

Open a request
Open the Smarti widget
Make sure the "Close Chat" Button is displayed
Scroll down the results

Observations

Most often I have observed this behavior in request mode
The result set should contain hits whose preview is displayed in different sizes.
The behavior occurs particularly frequently in search results of the Solr query builder.
A search query is made via XHR when scrolled to the very bottom, but no further results are displayed.
Even if the number of search hits found is reached, further search queries are executed. Example: numfound=13 but a Solr query with start=16 is executed
By fixing problem [Bug] Paging is missing #210, the number of hits is set to 6 (rows=6) on the client side by default to completely fill the hit display area. However, the hits per page are configured on the server side by design, whereby a separate value can be set for each Smarti client configuration. Therefore, the value for rows is always overwritten by the server-side configuration. (BTW: To fill the area of the result display completely, the available space for the hit display and the size of the individual results should be calculated/considered.
Since the the widget-footer is positioned absolute and overlays the widget-body, the scrollbar is behind the "Close Chat" button. Moreover the space between the "Close Chat" button and the results is much to large.

Acceptance criteria

the automatic reloading of results is triggered when the end of the results is reached
the presentation of the results in the UI is complete
it does not attempt to load further results if the number of hits found is already displayed in full.
initially, so many hits are always loaded that the available display area is fully utilized (provided there are enough hits).
the scrollbar is not covered by other elements (e.g. by the "Close Chat" button)
basic design decisions are taken into account in the client-side implementation (the page size should be configurable either server-side or client-side)

Environment

Smarti-Version: 0.7.0
Java-Version: 1.8

The text was updated successfully, but these errors were encountered:

Peym4n · 2018-03-21T12:05:56Z

I removed the hard-coded minimum number of initial rows. The server-side config will always be used.
The widget can now detect if all the results are loaded already, and won't try to load more.
After loading the initial data, the widget will check if the results area is filled. If not, it will try to load more when remaining results exist.
And the results area is now fully shown and the lower part is not hidden behind the button anymore.

ruKurz · 2018-05-10T17:26:07Z

There are still some issues when automatically loading further results.

The displayed number of results does not fit the effective found results (solr response server numfound)
The number of results changes unexpectedly when the lazy loading is triggered
When scrolling to the very bottom of a large result list, there are displayed less results than number of results is displayed on top (client e.g. rendering)
Sometimes there is displayed 0 (zero) results even there are results shown
Sometimes the last search result is covered by the "Finish Conversation" button

ruKurz · 2018-05-11T07:46:30Z

Sometimes there is displayed 0 (zero) results even there are results shown

ruKurz · 2018-05-11T07:51:54Z

The displayed number of results does not fit the effective found results.
When scrolling to the very bottom of a large result list, there are displayed less results than number of results is displayed on top

Here 71 results have been found:

After scrolling to the very bottom, there are displayed some 10 results (compare with 71):

ruKurz · 2018-05-11T07:54:41Z

Sometimes the last search result is covered by the "Finish Conversation" button.
And the scrollbar is covered by some elements.

Peym4n · 2018-05-11T11:15:40Z

Sometimes there is displayed 0 (zero) results even there are results shown

This has not happened to me. Is it reproducable?

After scrolling to the very bottom, there are displayed some 10 results (compare with 71)

The displayed number is the number of all available results which can be loaded by lazy loading, not the number of loaded results.

Sometimes the last search result is covered by the "Finish Conversation" button. And the scrollbar is covered by some elements.

Are you sure you are using the respective Rocket.Chat branch with the changes? (smarti-widget-0.7.1)
I already fixed this bug here.

ruKurz · 2018-05-11T13:02:07Z

All this can be reproduced on out test env where you have access to.

The displayed number is the number of all available results which can be loaded by lazy loading, not the number of loaded results.

Yes, I understand. But when 71 results are possible why does the lazy loading stop at round about 10?

Are you sure you are using the respective Rocket.Chat branch with the changes?

Yes I am. Have a look at our test env: smarti-0.7.2 and rc-0.63.3

ruKurz · 2018-05-11T13:24:40Z

Which browsers did you test?
And did you test the widget within the Rocket.Chat app?

Peym4n · 2018-05-14T08:51:09Z

Yes I am. Have a look at our test env: smarti-0.7.2 and rc-0.63.3

I checked the code on the test env and I couldn't find my rocket.chat changes.
So I think the changes are not merged yet. I will inform @mrsimpson.

ruKurz · 2018-05-14T09:01:27Z

We have deployed the Smarti artifact from https://github.com/redlink-gmbh/smarti/releases/tag/smarti-0.7.1

So this is independent from RC version

Peym4n · 2018-05-14T10:01:22Z

And regarding the 0 results:
I checked the test env. This happens when the widget is not able to load the next page of the conversations. Sometimes after sending a request to the widget backend, the widget receives no response, which means that there has been a problem between rocket.chat and smarti.
Anytime that happens (some results are loaded but 0 is displayed) one should check the RC logs for errors to find out what went wrong.
@mrsimpson

When the displayed number is not 0 and no more results are loaded, it's most probably because of a horizontal scrollbar on the bottom which prevents lazy loading. That's a UI bug and I will fix it.

* Smarti-203: Flag widget messages * Smarti-203: Rename widget message flag to skipAnalysis * Smarti-52: Add support for edited messages * redlink-gmbh/smarti#221: Set room topic as support area for conversation * Revert "redlink-gmbh/smarti#221: Set room topic as support area for conversation" This reverts commit c7966a3. * redlink-gmbh/smarti#225: Fix widget footer styling * redlink-gmbh/smarti#220: Improve error handling * SmartiWidgetBackend: Improve error handling

Peym4n · 2018-05-15T14:37:32Z

I'm working on an improved error handling in the widget.

ruKurz · 2018-06-04T13:39:59Z

The problems regarding the lazy loading behavior and the displayed result count are still persistent.
On our test env we have currently installed:

smarti-0.7.3 (Commit: 5d46505)
rocket-chat-0.63.3 (Commit: assistify/Rocket.Chat@6dec686)

@Peym4n Can you please verify, that those versions include you expected changes?

Peym4n · 2018-06-12T09:36:44Z

@Peym4n Can you please verify, that those versions include you expected changes?

Yes, the changes are correctly deployed.

Peym4n · 2018-06-12T10:26:47Z

Referring to this comment:

The displayed number of results does not fit the effective found results (solr response server numfound).
When scrolling to the very bottom of a large result list, there are displayed less results than number of results is displayed on top (client e.g. rendering)

See #255

The number of results changes unexpectedly when the lazy loading is triggered

See #256

Closing in favor of new issues.

ruKurz · 2018-06-12T14:13:26Z

I would like to let this issue opened until we have tested the upcoming release.

ruKurz · 2018-06-12T14:14:53Z

Moved the issue in: Needs Review
on: https://waffle.io/redlink-gmbh/smarti

Peym4n · 2018-06-12T14:20:34Z

@ruKurz ok. makes sense.

(cherry picked from commit 406eca9)

ruKurz · 2018-06-13T16:08:31Z

There are still some issues when automatically loading further results.

When scrolling to the very bottom of a large result list, there are displayed less results than number of results is displayed on top (client e.g. rendering)
Sometimes there is displayed 0 (zero) results even there are results shown
Sometimes the last search result is covered by the "Finish Conversation" button

Consider open points, that are not yet tested as done within this issue:

The displayed number of results does not fit the effective found results (solr response server numfound)
The number of results changes unexpectedly when the lazy loading is triggered

Those will be continued here:

* Fixing #345 - where outdated conversation id could not be found in smarti * Made serveral changes regarding the review. Added an admin option to re-synch completely. * Remove conversations from mapping cache, if a room is being ereased. Ordered private dunctions and added some comments. * Fixed i18n keys. * Get analysis and notify room after deleting a message. * Removed rate limiter and explicitly perform an conversation analysis. * Fixed several synchronisation issues related to the LivechatExternalMessage cache. * Removed interface method getRoomId. * removed unused SystemLogger * Improved error handling and debug/error messages. * Added missing _ definition * Resynch Limiter optimizied Restricted resynch access for admins Extracted synch to Smartiadapter Using getProperties instead legacy impl when sync * Refactored SmartiRelaod * Moved hooks to Assistify AI. Simplified clear method. * Make sure conversations being created when a new request, topic or thread is created * fixed system messages in smarti conversations * better rely on cache as long as the "legacy rc endpoint" does not work. * - Extracted functions - Increased readability - Code cleanups - Added comments * Fixing undefined vars & trailing-spaces * fixing undefined rid * Don't flush the cache if legacy webservice is not used * auto resync on message, resync livechat rooms * redlink-gmbh/smarti#225: Improve error handling (cherry picked from commit 406eca9) * fix duplicated room creation on new room * fixed test and minor bug in smarti adapter * fix linting * Use leagcy rocket.chat endpoint again when getting conversations * fixed assistify tests * removed redundant error logging from proxy * Improved health check before resynch * fix tests

ruKurz added bug ui labels Mar 17, 2018

ruKurz added this to the v0.7.1 milestone Mar 17, 2018

ruKurz changed the title ~~lazy result loading does in some cases~~ Automatic reloading of results does not work as expected Mar 17, 2018

ruKurz added the ready label Mar 17, 2018

westei assigned Peym4n Mar 19, 2018

Peym4n added in progress and removed ready labels Mar 20, 2018

Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Mar 20, 2018

redlink-gmbh/smarti#225: Fix widget footer styling

654d635

Peym4n pushed a commit that referenced this issue Mar 20, 2018

#225: Fix widget styling

e1200b7

Peym4n pushed a commit that referenced this issue Mar 21, 2018

#225: Fix endless scrolling

8b4c9d8

Peym4n added in review and removed in progress labels Mar 21, 2018

Peym4n pushed a commit that referenced this issue Mar 21, 2018

#225: Show loading animation at the end of the results area

7720690

ja-fra closed this as completed Apr 20, 2018

ghost removed the in review label Apr 20, 2018

ruKurz reopened this May 10, 2018

ruKurz modified the milestones: v0.7.1, 0.7.2 May 10, 2018

westei modified the milestones: 0.7.2, v0.7.3 May 14, 2018

Peym4n pushed a commit that referenced this issue May 14, 2018

#225: Prevent long message text break out

393bbae

westei modified the milestones: v0.7.3, v0.7.4 May 15, 2018

westei mentioned this issue May 15, 2018

CloudSync does not work for deleted Conversations #249

Closed

Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue May 15, 2018

redlink-gmbh/smarti#225: Improve error handling

406eca9

Peym4n pushed a commit that referenced this issue May 15, 2018

#225: Notify user of server errors

978f8e5

Peym4n added in review and removed in progress labels May 15, 2018

Peym4n closed this as completed Jun 12, 2018

Peym4n removed the in review label Jun 12, 2018

Peym4n mentioned this issue Jun 12, 2018

Smarti Widget 0.7.4 assistify/Rocket.Chat#349

Closed

ruKurz reopened this Jun 12, 2018

ruKurz added the in review label Jun 12, 2018

Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Jun 13, 2018

redlink-gmbh/smarti#225: Improve error handling

e384818

(cherry picked from commit 406eca9)

Peym4n mentioned this issue Jun 13, 2018

Smarti Widget 0.7.4 assistify/Rocket.Chat#352

Closed

ruKurz closed this as completed Jun 13, 2018

ruKurz removed the in review label Jun 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic reloading of results does not work as expected #225

Automatic reloading of results does not work as expected #225

ruKurz commented Mar 17, 2018 •

edited by Peym4n

Loading

Peym4n commented Mar 21, 2018

ruKurz commented May 10, 2018 •

edited

Loading

ruKurz commented May 11, 2018

ruKurz commented May 11, 2018 •

edited

Loading

ruKurz commented May 11, 2018 •

edited

Loading

Peym4n commented May 11, 2018

ruKurz commented May 11, 2018 •

edited

Loading

ruKurz commented May 11, 2018

Peym4n commented May 14, 2018

ruKurz commented May 14, 2018

Peym4n commented May 14, 2018 •

edited

Loading

Peym4n commented May 15, 2018

ruKurz commented Jun 4, 2018 •

edited

Loading

Peym4n commented Jun 12, 2018 •

edited

Loading

Peym4n commented Jun 12, 2018

ruKurz commented Jun 12, 2018

ruKurz commented Jun 12, 2018

Peym4n commented Jun 12, 2018

ruKurz commented Jun 13, 2018 •

edited

Loading

Automatic reloading of results does not work as expected #225

Automatic reloading of results does not work as expected #225

Comments

ruKurz commented Mar 17, 2018 • edited by Peym4n Loading

Expected Behaviour

Actual Behaviour

Steps to Reproduce

Observations

Acceptance criteria

Environment

Peym4n commented Mar 21, 2018

ruKurz commented May 10, 2018 • edited Loading

ruKurz commented May 11, 2018

ruKurz commented May 11, 2018 • edited Loading

ruKurz commented May 11, 2018 • edited Loading

Peym4n commented May 11, 2018

ruKurz commented May 11, 2018 • edited Loading

ruKurz commented May 11, 2018

Peym4n commented May 14, 2018

ruKurz commented May 14, 2018

Peym4n commented May 14, 2018 • edited Loading

Peym4n commented May 15, 2018

ruKurz commented Jun 4, 2018 • edited Loading

Peym4n commented Jun 12, 2018 • edited Loading

Peym4n commented Jun 12, 2018

ruKurz commented Jun 12, 2018

ruKurz commented Jun 12, 2018

Peym4n commented Jun 12, 2018

ruKurz commented Jun 13, 2018 • edited Loading

ruKurz commented Mar 17, 2018 •

edited by Peym4n

Loading

ruKurz commented May 10, 2018 •

edited

Loading

ruKurz commented May 11, 2018 •

edited

Loading

ruKurz commented May 11, 2018 •

edited

Loading

ruKurz commented May 11, 2018 •

edited

Loading

Peym4n commented May 14, 2018 •

edited

Loading

ruKurz commented Jun 4, 2018 •

edited

Loading

Peym4n commented Jun 12, 2018 •

edited

Loading

ruKurz commented Jun 13, 2018 •

edited

Loading