Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

CloudSync does not work for deleted Conversations #249

Closed
westei opened this issue May 15, 2018 · 5 comments
Closed

CloudSync does not work for deleted Conversations #249

westei opened this issue May 15, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@westei
Copy link
Member

westei commented May 15, 2018

Currently Conversations are deleted from the Repository. Because of this CloudSync does not work as this is based on the modified date of conversation.

Because of that Conversation are only deleted from the embedded SolrIndex on that host that performs the delete operation and stay in indexes of others.

This causes the SolrIndex to be out-of-sync with the state in the Repository.

To avoid this problems Conversations MUST NOT deleted from the repository but need to be marked as deleted as part of the deletion some/most of the information for those conversations can however be removed from the repository (e.g. all messages)

@westei westei added this to the v0.7.3 milestone May 15, 2018
@westei westei self-assigned this May 15, 2018
@westei westei modified the milestones: v0.7.3, v0.7.4 May 15, 2018
@westei
Copy link
Member Author

westei commented May 15, 2018

this blocks #225 as one of the mentioned Problems with the widget is actually caused by a NPE originating from this problem

westei added a commit that referenced this issue May 16, 2018
* Conversations are now marked as deleted and no longer directly deleted from the repository
@ruKurz
Copy link
Collaborator

ruKurz commented Jun 13, 2018

@westei I've no clue how to test this issue. Could you please provide some steps how to test this fix?

@westei
Copy link
Member Author

westei commented Jun 14, 2018

I used an ssh tunnel to a mongoDB running on a different host (ssh user@host -L 27017:127.0.0.1:27017)

Doing so simulates a cloud like setting wehre multiple Smarti instances do use the same MongoDB. The Smarti instance on host needs to use the cloud-sync feature to detect deletions you perform on the smarti instance on your localhost

@ruKurz
Copy link
Collaborator

ruKurz commented Jun 14, 2018

This test makes an elaborate impression on me.

@mrsimpson Do we have to test this?

@mrsimpson
Copy link
Collaborator

this test by @westei is a developers test and I believe it’s been performed with highest expertise available => let’s merge this and verify on our test environment

@ruKurz ruKurz closed this as completed Jun 14, 2018
@ruKurz ruKurz removed the in review label Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants