Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Deployment Instructions No Longer Work #2258

Closed
sopa301 opened this issue Dec 23, 2024 · 9 comments · Fixed by #2294 · May be fixed by reposense/publish-RepoSense#15
Closed

Netlify Deployment Instructions No Longer Work #2258

sopa301 opened this issue Dec 23, 2024 · 9 comments · Fixed by #2294 · May be fixed by reposense/publish-RepoSense#15
Assignees

Comments

@sopa301
Copy link
Contributor

sopa301 commented Dec 23, 2024

The problem

With the move to Java 11, the current instructions to deploy to Netlify no longer work as the default build image only has Java 8.

If possible, describe the solution

Add code to install Java 11 manually if the build system does not currently support it.

If applicable, describe alternatives you've considered

Discontinue support for Netlify deployments.

Additional context

A discussion on potential native Java 11 support

On a side note, the Netlify deployment for RepoSense has been down since March 2024.

@CYX22222003
Copy link
Contributor

CYX22222003 commented Jan 31, 2025

I have attempted to add a netlify.toml to the report-RepoSense repo to manually download the JDK for java 11. This seems to solve the issue and here is my deployed website and build log.
Here is the script

[build]
  command = """
  wget https://download.java.net/java/ga/jdk11/openjdk-11_linux-x64_bin.tar.gz &&
  tar -xvzf openjdk-11_linux-x64_bin.tar.gz &&
  mv jdk-11 ~/openjdk11 &&
  export JAVA_HOME=$HOME/openjdk11 &&
  export PATH=$JAVA_HOME/bin:$PATH &&
  pip install requests && ./run.sh
  """

  publish = "./reposense-report"
  base = "./"

@CYX22222003
Copy link
Contributor

@sopa301 May I know what is the current status of issue and which approach we are planning to take?

@sopa301
Copy link
Contributor Author

sopa301 commented Feb 11, 2025

I'm still in the process of obtaining the old token from Prof, though I'm not sure if it's still retrievable.

On the other hand, I'm curious as to your thoughts about how to resolve this issue. Which approach would you recommend?

@damithc
Copy link
Collaborator

damithc commented Feb 11, 2025

@sopa301 Send me your Netlify account username so that I can add you to the MarkBind team in Netlify.

@CYX22222003
Copy link
Contributor

CYX22222003 commented Feb 11, 2025

I'm still in the process of obtaining the old token from Prof, though I'm not sure if it's still retrievable.

On the other hand, I'm curious as to your thoughts about how to resolve this issue. Which approach would you recommend?

What I am proposing is to manually install and set the default java environment at the netlify server using the netlify.toml and I have tested with my fork repo. But I am not sure whether this approach is desirable in terms of efficiency.

@sopa301
Copy link
Contributor Author

sopa301 commented Feb 11, 2025

Prof @damithc I signed up with [email protected].

@CYX22222003 seems doable, as long as it's not too difficult for the user to replicate.
You can refer to this to see the current user guide for deploying on Netlify. We should aim to make it at least as easy to deploy to Netlify. Do let me know your thoughts on the feasibility of this task.

On a much lower priority, we also have a Netlify deployment and it would be nice to restore it, though it doesn't serve much purpose other than as proof that the Netlify deployment method works.

@damithc
Copy link
Collaborator

damithc commented Feb 11, 2025

Prof @damithc I signed up with [email protected].

@sopa301 Invitation sent.

@CYX22222003
Copy link
Contributor

Prof @damithc I signed up with [email protected].

@CYX22222003 seems doable, as long as it's not too difficult for the user to replicate. You can refer to this to see the current user guide for deploying on Netlify. We should aim to make it at least as easy to deploy to Netlify. Do let me know your thoughts on the feasibility of this task.

On a much lower priority, we also have a Netlify deployment and it would be nice to restore it, though it doesn't serve much purpose other than as proof that the Netlify deployment method works.

I see. Maybe we should update the relevant part of user guide only. Since deploying to Netlify is just one of many options of uploading, modifying the publish-RepoSense seems to be redundant and may confuse users.

@sopa301
Copy link
Contributor Author

sopa301 commented Feb 13, 2025

@CYX22222003 We've decided to put Netlify support on lower priority, so we'll need to modify the UG to match:

  • Update the Netlify appendix with the new instructions, with a warning that this method will not be supported going forward.
  • Update this page to recommend Github Actions instead of Netlify
  • Change other references as needed.

We've also decided to drop the Netlify deployment on RepoSense for the reasons discussed above.

jonasongg pushed a commit that referenced this issue Feb 16, 2025
Update Netlify build script

* Update the Netlify appendix method will not be supported going
forward.
* Update this page to recommend Github Actions instead of Netlify
* Change other references as needed.

Let's update relevant part of UG.
@github-project-automation github-project-automation bot moved this to Closed/Completed in RepoSense Roadmap Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Completed
3 participants