Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2258] Update user guide for Netlify deployment #2294

Merged
merged 17 commits into from
Feb 16, 2025
Merged

[#2258] Update user guide for Netlify deployment #2294

merged 17 commits into from
Feb 16, 2025

Conversation

CYX22222003
Copy link
Contributor

Fixes #2258

Proposed commit message

Update Netlify build script

* Update the Netlify appendix method
will not be supported going forward.
* Update this page to recommend Github
Actions instead of Netlify
* Change other references as needed.

Let's update relevant part of UG.

Other information

@CYX22222003 CYX22222003 marked this pull request as ready for review February 14, 2025 01:55
@CYX22222003 CYX22222003 mentioned this pull request Feb 14, 2025
Open
@CYX22222003 CYX22222003 requested a review from a team February 14, 2025 01:57
joeng03
joeng03 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@joeng03 joeng03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CYX22222003 CYX22222003 requested a review from a team February 14, 2025 02:24
sopa301
sopa301 requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work updating the documentation! I'm convinced that we should set up the netlify.toml script in advance after all since it's unlikely to be modified.

@CYX22222003 CYX22222003 requested a review from sopa301 February 14, 2025 05:32
sopa301
sopa301 reviewed Feb 14, 2025
View reviewed changes
damithc
damithc reviewed Feb 14, 2025
View reviewed changes
@CYX22222003 CYX22222003 requested a review from sopa301 February 14, 2025 12:11
sopa301
sopa301 requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continued effort.

The references in customizingReports.md can be kept for now until we figure out a replacement for the Netlify previews.

@CYX22222003 CYX22222003 requested a review from sopa301 February 15, 2025 01:50
sopa301
sopa301 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg merged commit 9876607 into reposense:master Feb 16, 2025
11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damithc damithc damithc left review comments

@joeng03 joeng03 joeng03 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify Deployment Instructions No Longer Work
5 participants
@CYX22222003 @damithc @joeng03 @sopa301 @jonasongg