-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pillow and cffi #39571
base: develop
Are you sure you want to change the base?
Bump pillow and cffi #39571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
both can be installed using homebrew but we don't use it. Shouldn't it be done here as well ?
|
good idea. can you do a PR (against my fork) to add these? |
OK, added the homebrew info. |
With the current PR, I can compile cffi. However, configure don't see the homebrew installation or don't want to use it. For pillow, the situation is even worse: it don't use the homebrew installation and it fails downloading it (see attached log file).
When I try to copy pillow to
|
I had issues with PyPI hosting yesterday too. It's flaky for some reason. @dcoudert - does the build work for you with pillow from Homebrew? I'd re-check checksums and compare them with the PyPI ones |
no. ./configure gives:
|
ah, these are python packages. You need |
sha256 from pypi (top, and bottom.on the branch) for cffi
ditto for pillow: top for pypi, bottom for the branch
so the hashes look ok, it's just a pythonhosted cite issue |
to review, you may download files from pypi using a browser, go to pypi.org and search for cffi resp. pillow, and get source tarballs, save them to upstream/ |
The download url seems to be wrong, what works for me is to use
with a lower-case P |
oh dear, I changed P to p in one of the two place 😭 |
Documentation preview for this PR (built with commit 01b057d; changes) is ready! 🎉 |
while I found https://forums.gentoo.org/viewtopic-t-1172213-start-0.html - I don't see how it's not a bug, as it shows that |
You're right but it's probably too late to get anyone to do anything about it. Pillow-11.0 should have added trove-classifiers with a lower bound to its build-deps when it was released, then Gentoo would have inherited it. Gentoo will update trove-classifiers before pillow, but only with The problem is already fading away because pip installs the latest versions, and a good enough version has been stable on Gentoo for a few months. So YMMV but I bet people will just groan if you report it now. |
This bumps pillow and cffi to the latest versions. I had trouble building older ones on macOS M1 machine
📝 Checklist
⌛ Dependencies