-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use precision 10 by default #2716
Comments
I'm really hoping this makes it into the next release, as I expect the Ruby ecosystem will be switching to libsass with the upcoming sassc and sassc-rails releases. |
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master to incorporate fixes for: 1. The :not selector. sass#91 sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also changes the location of libsass.so from ext/ to lib/ (fixes sass#95).
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master to incorporate fixes for: 1. The :not selector. sass#91 sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also changes the location of libsass.so from ext/ to lib/ (fixes sass#95).
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master to incorporate fixes for: 1. The :not selector. sass#91 sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Building with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Changes the location of libsass.so from ext/ to lib/. Fixes sass#95 2. No longer tries to run `nmake` on Windows (libsass Makefile is compatible with GNU Make only).
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
referenced
this issue
in kaj/rsass
Feb 2, 2019
Some cleanup and test updates in how numeric precision is handled.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dart Sass and Ruby Sass both use 10 digits of numeric precision by default. For consistency, and for the accuracy reasons outlined in sass/sass#1122, LibSass should follow suit.
The text was updated successfully, but these errors were encountered: