-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring Sass with multiple valid load paths leads to SyntaxError on Windows #93
Comments
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
Nov 17, 2018
Updates libsass to master ([d225a09a](https://github.com/sass/libsass/tree/d225a09a152050d569c077f97bb944c8dc819d6f)) to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 5, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
glebm
added a commit
to glebm/sassc-ruby
that referenced
this issue
May 8, 2019
Updates libsass to master to incorporate fixes for: 1. The :not selector. Fixes sass#91. sass/libsass#2697 2. Default precision changed to 10. sass/libsass#2716 3. Now builds with `cc` instead of hard-coding `gcc`. sass/libsass#2707 4. Building on Linux and Solaris. sass/libsass#2720 Also: 1. Adds Windows RubyInstaller compilation support via `rake-compiler`. Fixes sass#18. 2. Fixes `load_paths` separator on Windows. Fixes sass#93. 3. Changes the location of `libsass.so` from `ext/` to `lib/`. Fixes sass#95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello Guys 👋
Background
This issue was discovered while migrating Jekyll's built-in sass-converter to use
sassc-2.0.0
.Jekyll sites typically have two sass-load-paths pre-configured:
_sass
directory at the site's source root._sass
directory at the site's theme root (if the site uses a theme-gem e.g. Minima)Out-of-the box, a Jekyll site using the
sassc
branch (the migration PR linked above) yields no errors on both Unix based systems and Windows because the site is only loading sass files from the theme-gem.The issue arises when the Windows user adds a
_sass
directory at their site's source root (in order to override styles defined by the theme-gem).Now there exists two valid entries, in the
load_paths
array,Summary
SassC on Windows attempts to import a sass partial from one of the load_paths and just
raises
instead of checking the other load path for the imported partial as well.Misc.
Thanks.
/cc @am11
The text was updated successfully, but these errors were encountered: