[MRG] Release 0.3.0, pyproject.toml an Citations files #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rflamary
commented
Jul 5, 2024
•
rflamary
commented
- Add CITATION.cff file with all co-authors of SKADA
- Add citation information to readme
- cleanup version in setup files (use pyproject.toml)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 97.01% 96.99% -0.02%
==========================================
Files 54 54
Lines 5319 5319
==========================================
- Hits 5160 5159 -1
- Misses 159 160 +1 |
rflamary
changed the title
rflamary
changed the title
antoinecollas
approved these changes
Jul 5, 2024
kachayev
approved these changes
Jul 5, 2024
tomMoral
reviewed
Jul 5, 2024
| # Visit https://bit.ly/cffinit to generate yours today! | ||
|
|
||
| cff-version: 1.2.0 | ||
| title: 'SKADA : Scikit Adaptation' |
There was a problem hiding this comment.
Suggested change
| title: 'SKADA : Scikit Adaptation' | |
| title: 'SKADA: Scikit Adaptation' |
| authors: | ||
| - given-names: Théo | ||
| family-names: Gnassounou | ||
| affiliation: University Paris-Saclay, Inria, CEA |
There was a problem hiding this comment.
Suggested change
| affiliation: University Paris-Saclay, Inria, CEA | |
| affiliation: 'University Paris-Saclay, Inria, CEA' |
| family-names: Mellot | ||
| affiliation: 'University Paris-Saclay, Inria, CEA' | ||
| - given-names: Virginie | ||
| family-names: ' Loison' |
There was a problem hiding this comment.
Suggested change
| family-names: ' Loison' | |
| family-names: Loison |
| affiliation: 'University Paris-Saclay, Inria, CEA' | ||
| - given-names: Ambroise | ||
| family-names: Odonnat | ||
| affiliation: Huawei Noah’s Ark Lab |
There was a problem hiding this comment.
Suggested change
| affiliation: Huawei Noah’s Ark Lab | |
| affiliation: 'Huawei Noah’s Ark Lab' |
Comment on lines
+56
to
+59
| - machine learning | ||
| - scikit-learn | ||
| - pytorch | ||
| - domain adaptation |
There was a problem hiding this comment.
Suggested change
| - machine learning | |
| - scikit-learn | |
| - pytorch | |
| - domain adaptation | |
| - machine learning | |
| - domain adaptation | |
| - scikit-learn | |
| - pytorch |
Comment on lines
+13
to
+14
| {name = "SKADA Team"}, | ||
| ] |
There was a problem hiding this comment.
Suggested change
| {name = "SKADA Team"}, | |
| ] | |
| {name = "SKADA Team"}, | |
| ] |
| packages = ["skada"] | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {attr = "skada.version.__version__"} |
There was a problem hiding this comment.
Suggested change
| version = {attr = "skada.version.__version__"} | |
| version = {attr = "skada.version.__version__"} | |
There was a problem hiding this comment.
you can now remove this file with the pyproject.toml I think?
Or do you still need it for pip install -e .?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.