-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to plotting functions #511
Conversation
for more information, see https://pre-commit.ci
This reverts commit 61e2712.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
A little bit more context to the tasscoda issue:
even though ete3 is installed (see session info below), so I couldn't generate example plots for all tasscoda plotting functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Generally looks good. Let's fix the issues and finish the docstrings
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 63.99% 64.07% +0.07%
==========================================
Files 43 43
Lines 4969 4982 +13
==========================================
+ Hits 3180 3192 +12
- Misses 1789 1790 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank youu!!
Could we please remove the TODOs for adding the missing previews? They'll already render which isn't pretty.
I'm confident that @Lilly-May or whoever is going to add them will be able to identify them or they can look at the state of this PR before merging
Added plots: