Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter spaceAsPlus to ByteSerialize #888

Open
tuplecats opened this issue Nov 28, 2023 · 0 comments · May be fixed by #928 or #1028
Open

Add parameter spaceAsPlus to ByteSerialize #888

tuplecats opened this issue Nov 28, 2023 · 0 comments · May be fixed by #928 or #1028

Comments

@tuplecats
Copy link

Hello! I think it would be nice to be able to enable/disable replacing "%20" with "+" in ByteSerialize struct.

This parameter and its usage described here https://url.spec.whatwg.org/#string-percent-encode-after-encoding
@kaffarell kaffarell mentioned this issue Apr 30, 2024
Open
kaffarell added a commit to kaffarell/rust-url that referenced this issue Apr 30, 2024
@kaffarell
encode space to '%20' as per url standard
109e2f5 
Previously the space character was exclusively encoded to '+'. This is
wrong, as the URL Standard [0] specifies that the default is '%20'.
Another function has been introduced as well, which replicates the old
behavior and converts spaces to '+'.
Notice that this breaks the default behavior and could lead to bugs.

[0]: https://url.spec.whatwg.org/#string-percent-encode-after-encoding

Fixes: servo#927
Fixes: servo#888

Signed-off-by: Gabriel Goller <[email protected]>
@kaffarell kaffarell linked a pull request Apr 30, 2024 that will close this issue
Open
kaffarell added a commit to kaffarell/rust-url that referenced this issue Apr 30, 2024
@kaffarell
encode space to '%20' as per url standard
c23893a 
Previously the space character was exclusively encoded to '+'. This is
wrong, as the URL Standard [0] specifies that the default is '%20'.
Another function has been introduced as well, which replicates the old
behavior and converts spaces to '+'.
Notice that this breaks the default behavior and could lead to bugs.

[0]: https://url.spec.whatwg.org/#string-percent-encode-after-encoding

Fixes: servo#927
Fixes: servo#888

Signed-off-by: Gabriel Goller <[email protected]>
kaffarell added a commit to kaffarell/rust-url that referenced this issue Feb 17, 2025
@kaffarell
add option to encode space to '%20' as per url standard
a824f5c 
Per default the space character is exclusively encoded to '+'. This is
wrong, as the URL Standard [0] specifies that the default is '%20'.
PR servo#928 fixes this behavior, but is obviously a breaking change. To
introduce this feature early, add a new function that sets the correct
behavior. This way, we can use it without causing a breaking change.

[0]: https://url.spec.whatwg.org/#string-percent-encode-after-encoding

Fixes: servo#927
Fixes: servo#888

Signed-off-by: Gabriel Goller <[email protected]>
@kaffarell kaffarell linked a pull request Feb 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tuplecats