add option to encode space to '%20' as per url standard #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per default the space character is exclusively encoded to '+'. This is wrong, as the URL Standard [0] specifies that the default is '%20'. PR servo#928 fixes this behavior, but is obviously a breaking change. To introduce this feature early, add a new function that sets the correct behavior. This way, we can use it without causing a breaking change. [0]: https://url.spec.whatwg.org/#string-percent-encode-after-encoding Fixes: servo#927 Fixes: servo#888 Signed-off-by: Gabriel Goller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per default the space character is exclusively encoded to '+'. This is wrong, as the URL Standard 0 specifies that the default is '%20'. PR #928 fixes this behavior, but is obviously a breaking change. To introduce this feature early, add a new function that sets the correct behavior. This way, we can use it without causing a breaking change.
Fixes: #927
Fixes: #888