Babel runtime as a dependency #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why this changed? In any case, this is probably fine. Once CI passes, I'll merge. |
|
Including in #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new react-on-rails project according to this tutorial, the server logs errors about babel-runtime, e.g.
10:10:33 server.1 | ERROR in ./~/react-on-rails/node_package/lib/clientStartup.js 10:10:33 server.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:33 server.1 | @ ./~/react-on-rails/node_package/lib/clientStartup.js 8:17-64 10:10:33 server.1 | 10:10:33 server.1 | ERROR in ./~/react-on-rails/node_package/lib/ComponentStore.js 10:10:33 server.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/object/keys' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:33 server.1 | @ ./~/react-on-rails/node_package/lib/ComponentStore.js 7:12-56 10:10:33 server.1 | 10:10:33 server.1 | ERROR in ./~/react-on-rails/node_package/lib/ComponentStore.js 10:10:33 server.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/map' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:33 server.1 | @ ./~/react-on-rails/node_package/lib/ComponentStore.js 11:11-47 10:10:33 server.1 | 10:10:33 server.1 | ERROR in ./~/react-on-rails/node_package/lib/buildConsoleReplay.js 10:10:33 server.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:33 server.1 | @ ./~/react-on-rails/node_package/lib/buildConsoleReplay.js 9:17-64 10:10:33 server.1 | 10:10:33 server.1 | ERROR in ./~/react-on-rails/node_package/lib/serverRenderReactComponent.js 10:10:33 server.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:33 server.1 | @ ./~/react-on-rails/node_package/lib/serverRenderReactComponent.js 8:17-64 10:10:36 client.1 | Hash: fff86825b4cb1eddf6d7 10:10:36 client.1 | Version: webpack 1.12.14 10:10:36 client.1 | Time: 25030ms 10:10:36 client.1 | Asset Size Chunks Chunk Names 10:10:36 client.1 | app-bundle.js 4.85 MB 0 [emitted] app 10:10:36 client.1 | vendor-bundle.js 1.8 MB 1 [emitted] vendor 10:10:36 client.1 | [0] multi app 28 bytes {0} [built] 10:10:36 client.1 | [0] multi vendor 76 bytes {1} [built] 10:10:36 client.1 | + 754 hidden modules 10:10:36 client.1 | 10:10:36 client.1 | ERROR in ./~/react-on-rails/node_package/lib/clientStartup.js 10:10:36 client.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:36 client.1 | @ ./~/react-on-rails/node_package/lib/clientStartup.js 8:17-64 10:10:36 client.1 | 10:10:36 client.1 | ERROR in ./~/react-on-rails/node_package/lib/ComponentStore.js 10:10:36 client.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/object/keys' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:36 client.1 | @ ./~/react-on-rails/node_package/lib/ComponentStore.js 7:12-56 10:10:36 client.1 | 10:10:36 client.1 | ERROR in ./~/react-on-rails/node_package/lib/ComponentStore.js 10:10:36 client.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/map' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:36 client.1 | @ ./~/react-on-rails/node_package/lib/ComponentStore.js 11:11-47 10:10:36 client.1 | 10:10:36 client.1 | ERROR in ./~/react-on-rails/node_package/lib/serverRenderReactComponent.js 10:10:36 client.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:36 client.1 | @ ./~/react-on-rails/node_package/lib/serverRenderReactComponent.js 8:17-64 10:10:36 client.1 | 10:10:36 client.1 | ERROR in ./~/react-on-rails/node_package/lib/buildConsoleReplay.js 10:10:36 client.1 | Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /Users/alex/Development/personal/shaka/client/node_modules/react-on-rails/node_package/lib 10:10:36 client.1 | @ ./~/react-on-rails/node_package/lib/buildConsoleReplay.js 9:17-64The proposed fix adds babel-runtime to the dependencies.
This change is