-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generator to add ReactOnRails spec helper #362
Conversation
5d69c70
to
fee5e5e
Compare
Changes Unknown when pulling e6a6526 on add-rails-helper-to-generator into * on master*. |
e6a6526
to
42301a8
Compare
Changes Unknown when pulling 42301a8 on add-rails-helper-to-generator into * on master*. |
lib/generators/react_on_rails/base_generator.rb, line 194 [r2] (raw file): Comments from Reviewable |
lib/generators/react_on_rails/templates/redux/base/client/app/bundles/HelloWorld/containers/HelloWorld.jsx, line 14 [r2] (raw file): Comments from Reviewable |
Changes Unknown when pulling b7b2ca4 on add-rails-helper-to-generator into * on master*. |
Review status: 0 of 19 files reviewed at latest revision, 2 unresolved discussions. lib/generators/react_on_rails/base_generator.rb, line 194 [r2] (raw file): lib/generators/react_on_rails/templates/redux/base/client/app/bundles/HelloWorld/containers/HelloWorld.jsx, line 14 [r2] (raw file): Comments from Reviewable |
* Generator adds line to spec/rails_helper.rb so that running specs will ensure assets are compiled. * Added more diagnostics for server rendering. * Calls to setTimeout and setInterval are not logged for server rendering unless env TRACE_REACT_ON_RAILS is set to YES. * Other small changes to the generator including adding necessary npm scripts to allow React on Rails to build assets. * npm modules updated for generator. * Updated all npm dependencies to latest. * Update to node 5.10.0 for CI * Add babel-runtime as a peer dependency of npm module react-on-rails * Updated generators to have babel-runtime added
b7b2ca4
to
fa16c9a
Compare
Changes Unknown when pulling fa16c9a on add-rails-helper-to-generator into * on master*. |
lib/generators/react_on_rails/base_generator.rb, line 194 [r2] (raw file): Comments from Reviewable |
Reviewed 16 of 19 files at r1, 4 of 4 files at r2. Comments from Reviewable |
ensure assets are compiled.
rendering unless env TRACE_REACT_ON_RAILS is set to YES.
scripts to allow React on Rails to build assets.
This change is