fix: node10 types and implementation resolution #922
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following fixes for node10 module resolution:
@shikijs/vitepress-twoslash/cache-fs
resolving to default package export (expand https://arethetypeswrong.github.io/?p=%40shikijs%2Fvitepress-twoslash%402.3.2 then expant entrypoints/node10 resolution and implementation and check the filename, check screenshots below)/cc @antfu
About the *.mts
typesVersions
mapping inlangs
,langs-precompiled
andtheme
packages, it is a hack to allow resolve both types and implementation correctly, I've send you a few DM at discord with some screenshots with the traces for both.I also need to review a few repositories 😅
Linked Issues
Additional context
current cache-fs subpackage export
cache-fs subpackage export with this PR