Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: remove node10 typescript resolution support #923

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Feb 8, 2025

Description

From this comment #922 (comment)

This PR also removeing .d.ts generation, switching to declaration: 'node16' (unbuild config files).

Linked Issues

Additional context

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 4cde85c
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/67b431b4dddf860008aec5d6
😎 Deploy Preview https://deploy-preview-923--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 4cde85c
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/67b431b430252f0008e5c372
😎 Deploy Preview https://deploy-preview-923--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin marked this pull request as draft February 8, 2025 04:50
@antfu antfu changed the base branch from main to feat/v3-prepare February 17, 2025 07:02
@antfu antfu changed the base branch from feat/v3-prepare to main February 17, 2025 07:26
@antfu antfu changed the title build!: remove node10 support build!: remove node10 typescript resolution support Feb 17, 2025
@userquin
Copy link
Contributor Author

finally 🥳

@userquin userquin marked this pull request as ready for review February 17, 2025 15:09
@antfu antfu merged commit ccb5856 into shikijs:main Feb 18, 2025
11 of 12 checks passed
@userquin userquin deleted the remove-node10-support branch February 18, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants