-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump shipwright-io/build to v0.5.0 #19
Conversation
In v0.5.0, the BuildRun status fields "Succeeded" and "Reason" were removed. This was replaced by the condition type "Succeeded."
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @otaviof |
/cc @alicerum |
/lgtm |
@alicerum it isn't at all clear to me why the list test is failing after the kube rebase: === RUN TestResource/Resource_List
=== CONT TestResource
resource_test.go:52:
Error from List must be nil
Expected
<*errors.errorString | 0xc000538200>: {
s: "item[0]: can't assign or convert unstructured.Unstructured into v1alpha1.Build",
}
to be nil |
k8s 1.20's fake dynamic client returns an error trying to convert an unstructured type to the list's underlying type. Skipping the resource list unit test until the fake dynamic client is fixed upstream. See kubernetes/client-go#983
Decided to skip the unit test - the fake dynamic client is pretty brittle and provided on an "as-is" basis. |
An update about the issue found on this PR, when we start a fake dynamic-client with a Build object, it does func TestSimpleDynamicClientList(t *testing.T) {
g := gomega.NewGomegaWithT(t)
scheme := runtime.NewScheme()
buildv1alpha1.SchemeBuilder.AddToScheme(scheme)
b := &buildv1alpha1.Build{}
b.SetName("name")
client := fake.NewSimpleDynamicClient(scheme, b)
rs := client.Resource(buildv1alpha1.SchemeGroupVersion.WithResource("builds"))
res, err := rs.List(context.TODO(), metav1.ListOptions{})
g.Expect(err).To(gomega.BeNil())
g.Expect(res).ToNot(gomega.BeNil())
g.Expect(len(res.Items)).To(gomega.Equal(1))
} |
/lgtm We will tackle the root-cause of the test skipped here, so the current state looks good to me. |
@adambkaplan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Superseded by #34 |
Now that v0.5.0 has been released, we need to bump the CLI's dependencies.
This includes a fix for the breaking change to BuildRun's status field.