Bump shipwright-io/build to v0.5.0 (II) #34
Conversation
In v0.5.0, the BuildRun status fields "Succeeded" and "Reason" were removed. This was replaced by the condition type "Succeeded."
Remove import and later replace of `k8s.io/client-go` by just using the import.
k8s 1.20's fake dynamic client returns an error trying to convert an unstructured type to the list's underlying type. Skipping the resource list unit test until the fake dynamic client is fixed upstream. See kubernetes/client-go#983
|
I am currently working on the local source code EP and for this, I needed to play around with the CLI. For future updates, I would like to align the CLI a bit more to the current level of https://github.com/shipwright-io/build. That is why I wanted to start to bump the version to the latest level and sync the import style. @otaviof @alicerum Going forward, I would like to propose to replace the dynamic client with the specific client. I have done that task in https://github.com/homeport/build-load some time ago and can offer to do the same here again. |
HeavyWombat
added
the
kind/cleanup
Hi @HeavyWombat you can go ahead with that. There is consensus on that aspect I'd say. The issue is Review the Need for the Dynamic-Client #24. It was also discussed in the community meeting from June 21st. |
|
He @otaviof, @HeavyWombat rebased the commits from @adambkaplan from PR #19 that you had approved already. Can you approve this one? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Changes
Based on #19, but with an additional tweak for
client-goin the Go modules files. Otherwise, just cherry-picked the commits by @adambkaplan and fixed the merge conflict in Go sum:Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes