This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
adds validator flag to allow private ip addresses #18850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18850 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 443 443
Lines 126082 126294 +212
=========================================
+ Hits 104507 104636 +129
- Misses 21575 21658 +83 |
mvines
approved these changes
Jul 23, 2021
| @@ -21,6 +21,7 @@ use { | |||
| signature::{read_keypair_file, write_keypair_file, Keypair, Signer}, | |||
| system_program, | |||
| }, | |||
| solana_streamer::socket::SocketAddrSpace, | |||
There was a problem hiding this comment.
I think solana-test-validator should just allow private addresses by default (and it's probably fine to not have an option to only allow global this).
There was a problem hiding this comment.
yeah, true. I am merging this now not to get merge conflicts, but will follow up.
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
(cherry picked from commit d2d5f36) # Conflicts: # accounts-cluster-bench/Cargo.toml # bench-tps/Cargo.toml # cli/Cargo.toml # core/benches/cluster_info.rs # core/src/banking_stage.rs # core/src/broadcast_stage.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/broadcast_stage/standard_broadcast_run.rs # core/src/cluster_slots_service.rs # core/src/repair_service.rs # core/src/tvu.rs # core/src/validator.rs # dos/Cargo.toml # gossip/src/cluster_info.rs # gossip/src/crds_gossip_pull.rs # gossip/src/crds_gossip_push.rs # gossip/src/gossip_service.rs # local-cluster/Cargo.toml # local-cluster/src/cluster_tests.rs # local-cluster/tests/local_cluster.rs # rpc/Cargo.toml # rpc/src/rpc.rs # tokens/Cargo.toml # validator/Cargo.toml # validator/src/main.rs
mergify bot
added a commit
that referenced
this pull request
Jul 29, 2021
…18975) * adds validator flag to allow private ip addresses (#18850) (cherry picked from commit d2d5f36) # Conflicts: # accounts-cluster-bench/Cargo.toml # bench-tps/Cargo.toml # cli/Cargo.toml # core/benches/cluster_info.rs # core/src/banking_stage.rs # core/src/broadcast_stage.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/broadcast_stage/standard_broadcast_run.rs # core/src/cluster_slots_service.rs # core/src/repair_service.rs # core/src/tvu.rs # core/src/validator.rs # dos/Cargo.toml # gossip/src/cluster_info.rs # gossip/src/crds_gossip_pull.rs # gossip/src/crds_gossip_push.rs # gossip/src/gossip_service.rs # local-cluster/Cargo.toml # local-cluster/src/cluster_tests.rs # local-cluster/tests/local_cluster.rs # rpc/Cargo.toml # rpc/src/rpc.rs # tokens/Cargo.toml # validator/Cargo.toml # validator/src/main.rs * removes backport merge conflicts Co-authored-by: behzad nouri <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To address mainnet issue, #18728 excludes private ip addresses.
As a side effect,
system-performance-testsbroke:#18728 (comment)
Summary of Changes