This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
passes through --allow-private-addr to validators in system perf tests #18876
Merged
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:allow-private-addr
Jul 29, 2021
Merged
passes through --allow-private-addr to validators in system perf tests #18876
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:allow-private-addr
Jul 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e022ea
to
3c02dc3
Compare
121a6ab
to
5fbd72e
Compare
Codecov Report
@@ Coverage Diff @@
## master #18876 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 449 449
Lines 127171 127171
=======================================
+ Hits 105052 105100 +48
+ Misses 22119 22071 -48 |
5fbd72e
to
f5f1a86
Compare
t-nelson
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
behzadnouri
added a commit
that referenced
this pull request
Sep 25, 2021
…s (backport #18876) (#20180) * passes through --allow-private-addr to validators in system perf tests (#18876) (cherry picked from commit 81026f9) # Conflicts: # multinode-demo/bootstrap-validator.sh # multinode-demo/validator.sh # net/net.sh * removes backport merge conflicts * ignores RUSTSEC-2021-0115 Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
system-performance-tests
has been broken since #18728Summary of Changes
This commit passes through
--allow-private-addr
which was added in #18850 down to validators in system perf tests.Successful run of the buildkite job:
https://buildkite.com/solana-labs/system-performance-tests/builds/5129