Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

passes through --allow-private-addr to validators in system perf tests #18876

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

behzadnouri
Copy link
Contributor

@behzadnouri behzadnouri commented Jul 23, 2021

Problem

system-performance-tests has been broken since #18728

Summary of Changes

This commit passes through --allow-private-addr which was added in #18850 down to validators in system perf tests.

Successful run of the buildkite job:
https://buildkite.com/solana-labs/system-performance-tests/builds/5129

@behzadnouri behzadnouri force-pushed the allow-private-addr branch 8 times, most recently from 6e022ea to 3c02dc3 Compare July 27, 2021 16:38
@behzadnouri behzadnouri changed the title passes through --allow-private-addr to system-test validators passes through --allow-private-addr to validators in system perf tests Jul 27, 2021
@behzadnouri behzadnouri force-pushed the allow-private-addr branch 2 times, most recently from 121a6ab to 5fbd72e Compare July 27, 2021 18:04
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #18876 (f5f1a86) into master (9529284) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18876   +/-   ##
=======================================
  Coverage    82.6%    82.6%           
=======================================
  Files         449      449           
  Lines      127171   127171           
=======================================
+ Hits       105052   105100   +48     
+ Misses      22119    22071   -48     

@behzadnouri
Copy link
Contributor Author

@t-nelson @sakridge any objection to merging this?

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@behzadnouri behzadnouri merged commit 81026f9 into solana-labs:master Jul 29, 2021
@behzadnouri behzadnouri deleted the allow-private-addr branch July 29, 2021 19:04
mergify bot pushed a commit that referenced this pull request Sep 24, 2021
#18876)

(cherry picked from commit 81026f9)

# Conflicts:
#	multinode-demo/bootstrap-validator.sh
#	multinode-demo/validator.sh
#	net/net.sh
CriesofCarrots pushed a commit that referenced this pull request Sep 25, 2021
#18876)

(cherry picked from commit 81026f9)

# Conflicts:
#	multinode-demo/bootstrap-validator.sh
#	multinode-demo/validator.sh
#	net/net.sh
CriesofCarrots pushed a commit that referenced this pull request Sep 25, 2021
#18876)

(cherry picked from commit 81026f9)

# Conflicts:
#	multinode-demo/bootstrap-validator.sh
#	multinode-demo/validator.sh
#	net/net.sh
behzadnouri added a commit that referenced this pull request Sep 25, 2021
…s (backport #18876) (#20180)

* passes through --allow-private-addr to validators in system perf tests (#18876)

(cherry picked from commit 81026f9)

# Conflicts:
#	multinode-demo/bootstrap-validator.sh
#	multinode-demo/validator.sh
#	net/net.sh

* removes backport merge conflicts

* ignores RUSTSEC-2021-0115

Co-authored-by: behzad nouri <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants