rest: handle endpoints that don't output json #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpackham
referenced
this pull request
Jan 27, 2017
If the json loads function raises, the return content is invalid. The function should log the error and raise the exception. Closes #32 Change-Id: I053b0169c8da47f2a4812cc30783f8a4776f9c2b
|
@dpursehouse do you want this over in pygerrit2? |
The /changes/<id>/revisions/current/patch?zip endpoint doesn't return json output but a binary data (the zipped contents of the change). The usual get() function raises a ValueError when faced with this. As a workaround provide a get_raw() function to allow callers to handle the decoding of data.
|
@cpackham thanks for the patch. Let's fix this over on pygerrit2, and then I'll backport it over here. We can leave this PR open until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /changes//revisions/current/patch?zip endpoint doesn't
return json output but a binary data (the zipped contents of the
change). The usual get() function raises a ValueError when
faced with this. As a workaround provide a get_raw() function
to allow callers to handle the decoding of data.