Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add simple web-based dashboard for cluster states #62

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

sbernauer
Copy link
Member

Very simple, but already helpful
image

@sbernauer sbernauer self-assigned this Feb 20, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Why not use a templating engine like askama or the faster rinja which both provide compile-time and type-safe templates?

Also, I'm not a huge fan of inline HTML in Rust code and would rather like to see it maintained in actual HTML files.

NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 20, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice touch. I trust these will also be available via as metrics too?

@sbernauer
Copy link
Member Author

Yes, there are metrics too. However I'm currently basically spamming F5 in the browser, so a quick and short feedback loop is nice.
This is just some quick addition to make debugging easier - many stats about the clusters are missing. As I'm looking into this issue for a customer, I don't want them to pay for other random stuff not directly needed for the feature I'm adding for them. Having a crate do it is likely better, but also takes longer as I have never used them.

@sbernauer
Copy link
Member Author

@Techassi pls heave a look at 800db29

@NickLarsenNZ
Copy link
Member

Now do dark mode 😄

@Techassi
Copy link
Member

@Techassi pls heave a look at 800db29

Yes, that's exactly what I had in mind. Thank you for implementing it!

@sbernauer sbernauer added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 6eff077 Feb 24, 2025
8 of 9 checks passed
@sbernauer sbernauer deleted the feat/simple-cluster-stats-dashboard branch February 24, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

3 participants