Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit duplicate defines in C Headers #46

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

stefanlippuner
Copy link
Contributor

Hey @tgingold-cern

This is a follow-up for #44

Changes:

  • Fix C constants generation with same c_name between register and field
  • Add more C syntax checks using gcc -fsyntax-only -Wall -Werror (check_c_syntax function).
  • Add #include <stdint.h> to C header files. This is required for the uint32_t/... types.

@lorenzschmid FYI

Related to #45

@stefanlippuner stefanlippuner marked this pull request as ready for review May 23, 2024 16:05
@stefanlippuner stefanlippuner changed the title Same label c Omit duplicate defines in C Headers May 24, 2024
This had already been fixed for the other constants formats in dc94972.
But, the C generator uses a separate `pr_field` function.
Compilation tests now also check headers standalone. Use `gcc -fsyntax-only`
instead of `gcc -S`.
@stefanlippuner
Copy link
Contributor Author

Based on feedback from @lorenzschmid I've also enabled the same-label test for VHDL/V/SV constants generation.

@tgingold-cern tgingold-cern merged commit 1db5c3b into tgingold-cern:master Jun 11, 2024
2 checks passed
@tgingold-cern
Copy link
Owner

Thanks (and sorry for the delay).

@stefanlippuner
Copy link
Contributor Author

No worries. Thanks for having a look and merging this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants