Implement support for markers specified for package dependencies in p…

[frenzymadness]

Fixes: #186

This introduces a breaking change

• Yes
• No

Needs to implement a test.

[frenzymadness]

The basic implementation is ready including some tests. I'd also like implement one more test with a combination of default and devel packages. Also, I have to check mypy issues.

[abompard]

Now I'm getting this traceback:

Traceback (most recent call last):
  File "/home/abompard/tmp/test-poetry/micropipenv.py", line 780, in install_poetry
    pipfile_lock = _poetry2pipfile_lock()
  File "/home/abompard/tmp/test-poetry/micropipenv.py", line 732, in _poetry2pipfile_lock
    if category[dependency_name].get("markers", None):
KeyError: 'twisted-iocpsupport'

I suppose it happens when the dependency appears in the lockfile after the package that depends on it.
I'm attaching my poetry.lock file (renamed to txt for github upload compatibility).

[frenzymadness]

I suppose it happens when the dependency appears in the lockfile after the package that depends on it.
I'm attaching my poetry.lock file (renamed to txt for github upload compatibility).

Thank you. I've fixed that and used that example as a new test. I've also tested that the micropipenv does not try to install the windows-only package.

Also, I've managed to fix mypy errors so unless we find more cases when this implementation does not work this should be ready for a review and merge.

[frenzymadness]

There is some problem on Windows, but it does not seem to be related to this change. It seems to be an issue with TemporaryDirectory in pytest_configure but I don't know any details.

[abompard]

Yep, it works on my local machine too :-)

[fridex]

Did a brief review - changes look good to me. I did not test them though (I do not use poetry that much). @frenzymadness if you think this is ready to be merged, I'm also in favour of giving green to this PR - the feedback is reasonable and the implementation looks well tested. The current release does not work properly, as reported.

@frenzymadness thanks for the great work 👍🏻
@abompard thanks for the support and feedback 👍🏻

[frenzymadness]

In the last iteration, I've implemented parentheses so the final combined markers look for example like this: "(python_version < \"3.8\") or (python_version <= \"3.7\")".

[frenzymadness]

The link to the pre-commit test does not work 😞

[fridex]

/test pre-commit

[harshad16]

Our ci is currently unable to show the error on the display, the error are the following:

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/data/install/pipenv_env_vars_default/Pipfile.lock
Fixing tests/data/install/pipenv_vcs_editable/Pipfile.lock
Fixing tests/data/install/pipenv_env_vars/Pipfile.lock
Fixing tests/data/install/pipenv_iter_index/Pipfile.lock
Fixing tests/data/install/pipenv_editable/Pipfile.lock
Fixing tests/data/install/pipenv_file/Pipfile.lock
Fixing tests/data/install/pipenv_vcs/Pipfile.lock
Fixing tests/data/install/pipenv/Pipfile.lock

pydocstyle...............................................................Failed
- hook id: pydocstyle
- exit code: 1

micropipenv.py:169 in public function `normalize_package_name`:
        D400: First line should end with a period (not '3')
micropipenv.py:169 in public function `normalize_package_name`:
        D401: First line should be in imperative mood; try rephrasing (found 'Implementation')
tests/test_micropipenv.py:936 in public function `test_normalize_package_name`:
        D103: Missing docstring in public function

First error can be easily solved by running: pre-commit run --all-files
second error is from doc_string, please update the docstring for provided errors.

How to reproduce:
execute following command in the branch: pre-commit run --all-files

[frenzymadness]

Thanks for your help @harshad16! pre-commit is now happy at least on my machine.

[fridex]

Changes look good to me. The addition seems to be well tested and already helped users. @frenzymadness happy to have this in, thanks for the great work 👍🏻

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fridex]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment