Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.1.1 #191

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Version 1.1.1 #191

merged 1 commit into from
Sep 22, 2021

Conversation

fridex
Copy link
Collaborator

@fridex fridex commented Sep 21, 2021

Related Issues and Dependencies

Related: #188

This introduces a breaking change

  • No

@sesheta sesheta requested a review from KPostOffice September 21, 2021 07:19
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2021
@fridex
Copy link
Collaborator Author

fridex commented Sep 21, 2021

/assign @frenzymadness

PTAL, I was not sure if this version should be 1.1.1 or 1.2.0 semantically.

frenzymadness
frenzymadness requested changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with 1.1.1 - we are basically fixing a bug in poetry implementation which is what is the last number for. But you have forgotten to change the version in the main module.

@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2021
@fridex
Copy link
Collaborator Author

fridex commented Sep 21, 2021

I agree with 1.1.1 - we are basically fixing a bug in poetry implementation which is what is the last number for. But you have forgotten to change the version in the main module.

Thanks for the catch 👍🏻 Adjusted in 637c2ee. PTAL

frenzymadness
frenzymadness approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sesheta
Copy link
Member

sesheta commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frenzymadness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@sesheta sesheta merged commit 94b5ba1 into thoth-station:master Sep 22, 2021
@fridex fridex deleted the v1.1.1 branch September 22, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzymadness frenzymadness frenzymadness approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@harshad16 harshad16 Awaiting requested review from harshad16 harshad16 is a code owner

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@frenzymadness frenzymadness

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @frenzymadness