Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): specify default inspector context #11375

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Dec 3, 2019

NOTE: REQUIRES #11294
  • Specify default inspector client context
TEST CASE
appc run -p android --debug-host localhost:8989
  1. Open chrome-devtools:// link in chrome-based browser.
  2. Open Console, enter Titanium.
  3. Should not experience crash.
DEMO

JIRA Ticket

@build
Copy link
Contributor

build commented Dec 3, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6677 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 69e7698

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change seems fine

@ssekhri
Copy link

ssekhri commented Dec 6, 2019

@garymathews The issue is still reproducible. Tried on both emulator as well as device and the app crashes when typing in console.
Following was shown in the build logs

[ERROR] v8:
[ERROR] v8:
[ERROR] v8: #
[ERROR] v8: # Fatal error in , line 0
[ERROR] v8: #
[ERROR] v8: unimplemented code
[ERROR] v8:
[ERROR] v8: #
[ERROR] v8: #
[ERROR] v8: #
[ERROR] v8: #FailureMessage Object: 0xff8ddf40

Tested on:
Mac OS: 10.15.1
SDK: 9.0.0.v20191203140045 (SDK for this PR)
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Device: Nexus4(v5.1.1) device, Pixel3(v10.0) emulator

@garymathews
Copy link
Contributor Author

@ssekhri You'll have to wait for #11294 to be merged, V8 7.8 includes this which is required for this to function correctly.

@garymathews
Copy link
Contributor Author

@ssekhri @lokeshchdhry #11294 has been merged, this is ready for review now 👍

@ssekhri
Copy link

ssekhri commented Dec 12, 2019

FR Passed. No crash when using console during debug using chrome-devtools.
Verified on:
Mac OS: 10.15.1
SDK: 9.0.0.v20191211163854
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Device: Nexus4(v5.1.1)

@ssekhri ssekhri merged commit c29960d into tidev:master Dec 12, 2019
drauggres pushed a commit to NetrisTV/titanium_mobile that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants