Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): specify default inspector context #11375

Merged
merged 2 commits into from
Dec 12, 2019
Merged

fix(android): specify default inspector context #11375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70c0a5c
fix(android): specify default inspector context
Dec 3, 2019
69e7698
Merge branch 'master' into TIMOB-27527
garymathews Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions android/runtime/v8/src/native/InspectorClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <v8-inspector.h>

#include "KrollBindings.h"
#include "V8Runtime.h"

namespace titanium {

Expand Down Expand Up @@ -49,6 +50,13 @@ class InspectorClient : public v8_inspector::V8InspectorClient
*/
static void Initialize(v8::Local<v8::Object>, v8::Local<v8::Context>);

/**
* Override to specify valid default context.
*/
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override {
return V8Runtime::GlobalContext();
}

private:
static const int kContextGroupId = 1;
const int kInspectorClientIndex = v8::Context::kDebugIdIndex + 1;
Expand Down